Mryange opened a new pull request, #63059:
URL: https://github.com/apache/doris/pull/63059
### What problem does this PR solve?
Issue Number: N/A
Problem Summary:
BE code currently allows assert_cast usages where From and To are
effectively the same type after removing cv/ref qualifiers, so a large number
of no-op casts have accumulated across column, expression, storage, and format
code. This weakens the signal of assert_cast, obscures the real static type of
nullable maps and result columns, and leaves obviously redundant casts
unnoticed during development.
Root cause: assert_cast only checked the requested cast form and did not
reject semantically identical types such as cv/ref-qualified aliases or pointer
variants with cv-qualified pointees. This change normalizes assert_cast
template arguments, adds a compile-time static_assert to ban same-type casts,
and updates the existing C++ call sites to use direct access or explicit
static_cast only where the holder is still base-typed.
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
