eldenmoon commented on code in PR #63104:
URL: https://github.com/apache/doris/pull/63104#discussion_r3212983273
##########
be/src/exec/common/variant_util.cpp:
##########
@@ -1374,27 +1293,37 @@ Status
VariantCompactionUtil::get_extended_compaction_schema(
?
empty_extended_info
: info_it->second;
auto& paths_set_info = uid_to_paths_set_info[column->unique_id()];
- if (ng_root_uids.contains(column->unique_id())) {
- const auto plan =
build_nested_group_compaction_materialization_plan(
- uid_to_existing_ng_subcolumns.contains(column->unique_id())
- ?
uid_to_existing_ng_subcolumns.at(column->unique_id())
- : std::vector<TabletColumnPtr> {},
- extended_info);
- append_nested_group_compaction_columns(target, column, plan,
output_schema,
- paths_set_info);
- LOG(INFO) << "Variant column uid=" << column->unique_id()
- << " keeps nested-group root with regular extracted
columns in compaction "
- "schema";
- continue;
- }
- if (!should_check_variant_path_stats(*column)) {
- VLOG_DEBUG << "skip extended schema compaction for variant uid="
<< column->unique_id()
- << " because the column disables variant path stats";
- continue;
+ const bool use_nested_group_compaction_schema =
ng_root_uids.contains(column->unique_id());
+ if (!use_nested_group_compaction_schema) {
+ if (!should_check_variant_path_stats(*column)) {
+ VLOG_DEBUG << "skip extended schema compaction for variant
uid="
+ << column->unique_id()
+ << " because the column disables variant path
stats";
+ continue;
+ }
+ if (extended_info.has_nested_group) {
+ LOG(INFO) << "Variant column uid=" << column->unique_id()
+ << " has nested group, keep original column in
compaction schema";
+ continue;
+ }
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
