github-actions[bot] commented on code in PR #63128:
URL: https://github.com/apache/doris/pull/63128#discussion_r3216371909


##########
fe/fe-core/src/main/java/org/apache/doris/catalog/BuiltinAggregateFunctions.java:
##########
@@ -135,8 +137,10 @@ private BuiltinAggregateFunctions() {
                 agg(BoolOr.class, "bool_or", "boolor_agg"),
                 agg(BoolAnd.class, "bool_and", "booland_agg"),
                 agg(BoolXor.class, "bool_xor", "boolxor_agg"),
-                agg(CollectList.class, "collect_list", "group_array"),
-                agg(CollectSet.class, "collect_set", "group_uniq_array"),
+                agg(CollectList.class, "collect_list_v1"),

Review Comment:
   This makes every public `collect_list` / `group_array` call resolve to the 
new BE symbol `collect_list_v2` immediately. In a rolling upgrade with the new 
FE and any old BE, the fragment sent to that old BE will reference 
`collect_list_v2`, but the old BE only registers `collect_list`/`collect_set`; 
it does not know either `*_v2` or the newly-added `*_v1` aliases. The added BE 
aliases therefore do not provide downgrade compatibility. Please gate the v2 
symbol by BE capability/`be_exec_version` and fall back to the original 
`collect_list`/`collect_set` names until all selected backends support v2.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to