github-actions[bot] commented on code in PR #62589:
URL: https://github.com/apache/doris/pull/62589#discussion_r3224701222
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/RuntimeFilterTranslator.java:
##########
@@ -228,6 +230,18 @@ private void
createLegacyRuntimeFilterFromGroup(List<RuntimeFilter> group,
Expr targetExpr = targetExprList.get(i);
origFilter.addTarget(new RuntimeFilterTarget(
scanNode, targetExpr, true, isLocalTarget));
+ RuntimeFilterPartitionPruneClassifier.Classification
classification =
Review Comment:
This grouped-RF path still classifies `curTargetExpression` even when the
legacy `targetExpr` was just wrapped in the type-adjustment `CastExpr` above.
The single-filter path now tracks `adjustedAfterNonIdentity` and skips
classification in that case, but grouped filters do not, so a grouped RF target
like `date_trunc(part_col)` that needs an outer cast can still be marked
partition-prunable based on the pre-cast Nereids expression while BE evaluates
partition endpoints through the post-cast legacy expression. That can produce
unsafe projected boundaries and false-prune partitions. Please mirror the
single-filter guard here, or classify an equivalent expression that includes
the inserted cast, and add grouped-RF coverage for this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
