Mryange commented on code in PR #63161:
URL: https://github.com/apache/doris/pull/63161#discussion_r3225378348
##########
be/src/exprs/aggregate/aggregate_function_sequence_match.h:
##########
@@ -73,10 +73,10 @@ constexpr auto sequence_match_max_iterations = 1000000l;
template <PrimitiveType T, typename Derived>
struct AggregateFunctionSequenceMatchData final {
using Timestamp = typename PrimitiveTypeTraits<T>::CppType;
- using NativeType =
- std::conditional_t<T == TYPE_DATEV2, uint32_t,
- std::conditional_t<T == TYPE_DATETIMEV2,
uint64_t,
- typename
PrimitiveTypeTraits<T>::CppType>>;
+ using NativeType = std::conditional_t<
Review Comment:
我看下面有的代码是用
using NativeType = typename PrimitiveTypeTraits<T>::StorageFieldType;
这里是不是也可以这样啊
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
