Mryange opened a new pull request, #63174:
URL: https://github.com/apache/doris/pull/63174
### What problem does this PR solve?
Issue Number: N/A
Problem Summary:
Aggregate batch deserialization creates aggregate states with placement new
before deserializing or merging serialized input. If deserialization or merge
throws after `create()` succeeds, the previous cleanup only destroyed states
from earlier rows and skipped the current already-created state. This can leak
resources owned by aggregate state objects, such as hash sets or bitmap
internals.
Root cause: the exception cleanup destroyed only states from previous rows.
If the current row's state was created successfully and deserialization failed
afterward, that current state was excluded from cleanup.
This PR tracks the number of successfully created aggregate states and
destroys exactly that range on exception. It preserves the successful-path
ownership model: `deserialize_vec()` leaves created states to its caller, while
merge helpers still release temporary rhs states with `destroy_vec()` after
successful merge.
This PR also switches aggregate-local `phmap::flat_hash_map` and
`phmap::flat_hash_set` usages to Doris wrapper aliases so they use Doris'
default equality and allocator definitions consistently.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
