FayneBupt commented on code in PR #62689:
URL: https://github.com/apache/doris/pull/62689#discussion_r3226068409
##########
be/src/exec/pipeline/pipeline_fragment_context.cpp:
##########
@@ -2238,7 +2289,7 @@ Status PipelineFragmentContext::send_report(bool done) {
// a internal cancellation being processed
// When limit is reached the fragment is also cancelled, but
_is_report_on_cancel will
// be set to false, to avoid sending fault report to FE.
- if (!_is_report_success && !_is_report_on_cancel) {
Review Comment:
感谢提醒,这里确实不应该感知具体 writer 类型。我已经把这部分改动去掉了,send_report() 的取消上报逻辑保持原有行为。Paimon
commit message 的收集现在只放在正常的 report status 参数填充流程里处理。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]