csun5285 commented on code in PR #63153:
URL: https://github.com/apache/doris/pull/63153#discussion_r3231087268
##########
be/src/storage/segment/column_reader.cpp:
##########
@@ -346,16 +346,16 @@ void ColumnReader::check_data_by_zone_map_for_test(const
MutableColumnPtr& dst)
#endif
Status ColumnReader::init(const ColumnMetaPB* meta) {
- _type_info = get_type_info(meta);
+ _type = (FieldType)meta->type();
if (meta->has_be_exec_version()) {
_be_exec_version = meta->be_exec_version();
}
- if (_type_info == nullptr) {
+ if (_type == FieldType::OLAP_FIELD_TYPE_NONE || _type ==
FieldType::OLAP_FIELD_TYPE_UNKNOWN) {
Review Comment:
这个是遗传代码，这俩type 获取typeinfo 的时候是nullptr，逻辑上一样，这块可能是为了防止啥错误吧
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
