eldenmoon commented on code in PR #63182:
URL: https://github.com/apache/doris/pull/63182#discussion_r3232032041
##########
fe/fe-core/src/main/java/org/apache/doris/load/routineload/RoutineLoadJob.java:
##########
@@ -2110,7 +2110,7 @@ private void validateFlexiblePartialUpdateForAlter()
throws UserException {
}
OlapTable olapTable = (OlapTable) table;
- // Validate table-level constraints (MoW, skip_bitmap,
light_schema_change, variant columns)
+ // Validate table-level constraints (MoW, skip_bitmap,
light_schema_change)
Review Comment:
Fixed in current head c6c7e55784466762e2c9ef066a99a94c5a012418.
`validateFlexiblePartialUpdateForAlter()` now validates the effective
post-ALTER state: it computes the resulting update mode, merges current job
properties with ALTER properties, checks incoming/current jsonpaths and
fuzzy_parse, and validates incoming/current COLUMNS while
`KafkaRoutineLoadJob.modifyProperties()` holds the job write lock before
mutating state. Added FE UT coverage for altered jsonpaths/fuzzy/COLUMNS and
regression ALTER negative cases for mode+jsonpaths and existing flexible jobs
later altered with jsonpaths/fuzzy/COLUMNS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
