github-actions[bot] commented on code in PR #63182:
URL: https://github.com/apache/doris/pull/63182#discussion_r3235006121
##########
gensrc/proto/olap_file.proto:
##########
@@ -791,6 +791,7 @@ message PartialUpdateInfoPB {
optional int32 nano_seconds = 13 [default = 0];
optional UniqueKeyUpdateModePB partial_update_mode = 14 [default = UPSERT];
optional PartialUpdateNewRowPolicyPB partial_update_new_key_policy = 15
[default = APPEND];
+ optional int32 sequence_map_col_uid = 16 [default = -1];
Review Comment:
Persisting `sequence_map_col_uid` is only effective if every partial-update
writer initializes it. The classic `RowsetBuilder` path passes
`table_schema_param->sequence_map_col_uid()` into `PartialUpdateInfo::init()`,
but `DeltaWriterV2::_build_current_tablet_schema()` still calls `init()`
without that argument, so load-v2 sinks keep the default `-1`. A concrete
failure path is a flexible partial update on a table with
`function_column.sequence_col`/sequence-map column through `VTabletWriterV2`:
when the old row is delete-signed and the input omits the sequence-map column,
`fill_non_primary_key_cell_for_*()` compares the column unique id with
`info->sequence_map_col_uid()`. Because it is `-1`, the sequence-map value is
treated like an ordinary skipped column and defaulted/null-filled instead of
being preserved with the hidden sequence column, which is exactly the case the
new sequence-map check is meant to protect for later merge-on-read compaction.
Please pass `table_schema_param
->sequence_map_col_uid()` in the DeltaWriterV2 initialization path as well,
and add coverage for flexible partial update on a sequence-map table using the
load-v2 sink.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
