airborne12 opened a new pull request, #63230:
URL: https://github.com/apache/doris/pull/63230
### What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary:
Fix BE compilation failures on macOS libc++ while keeping the Linux path on
the original `std::atomic<std::shared_ptr<...>>` implementation. `MultiVersion`
now uses the existing Doris `atomic_shared_ptr` fallback only when `USE_LIBCPP`
is enabled, and `MemLimiter` avoids mixed `long`/`int64_t` template deduction
in `std::max`.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [x] Manual test (add detailed scripts or steps below)
- `./build.sh --be -j 30`
- `clang-tidy` changed-line checks for modified files using
clang-tidy 20 with a temporary no-PCH compilation database because
`build-support/run-clang-tidy.sh` requires Bash associative arrays unavailable
in macOS bash 3.2
- `build-support/clang-format.sh be/src/common/multi_version.h` was
attempted but could not run because llvm@16 clang-format is not installed
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [x] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
