foxtail463 commented on code in PR #63299:
URL: https://github.com/apache/doris/pull/63299#discussion_r3252613012
##########
fe/fe-core/src/main/java/org/apache/doris/common/profile/ExecutionProfile.java:
##########
@@ -224,48 +225,56 @@ public Status updateProfile(TQueryProfile profile,
TNetworkAddress backendHBAddr
return new Status(TStatusCode.INVALID_ARGUMENT, "QueryId is not
set");
}
- if (!profile.isSetFragmentIdToProfile()) {
- LOG.warn("{} FragmentIdToProfile is not set",
DebugUtil.printId(profile.getQueryId()));
- return new Status(TStatusCode.INVALID_ARGUMENT,
"FragmentIdToProfile is not set");
+ if (!profile.isSetFragmentIdToProfileNodeReports()) {
Review Comment:
The impact is limited to profile visibility during rolling
upgrade. Query execution status, load progress and correctness are not
affected.
Since this report path is only for profile collection and the new structured
field is
the intended format after decoupling profile node reports from the display
tree, I
would prefer not to add legacy fallback
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
