github-actions[bot] commented on code in PR #63182:
URL: https://github.com/apache/doris/pull/63182#discussion_r3253311000
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/OlapTable.java:
##########
@@ -3197,10 +3197,16 @@ public boolean getEnableUniqueKeySkipBitmap() {
* 1. Must be MoW unique key table
* 2. Must have skip_bitmap column
* 3. Must have light_schema_change enabled
- * 4. Cannot have variant columns
* @throws UserException if any constraint is not satisfied
*/
public void validateForFlexiblePartialUpdate() throws UserException {
+ validateForFlexiblePartialUpdate(true);
+ }
+
+ /**
+ * Validate that the table supports flexible partial update.
+ */
+ public void validateForFlexiblePartialUpdate(boolean
validateBackendCapability) throws UserException {
if (!getEnableUniqueKeyMergeOnWrite()) {
Review Comment:
This table-level validator still omits the cluster-key restriction that
every partial-update planner enforces later. A concrete path is a UNIQUE MoW
table with cluster keys: `ALTER TABLE ... ENABLE FEATURE
"UPDATE_FLEXIBLE_COLUMNS"` reaches this validator and can add the hidden
skip-bitmap column, but any later flexible partial update load is rejected by
`NereidsStreamLoadPlanner` / `NereidsLoadingTaskPlanner` with the cluster-key
partial-update check. Please reject `isUniqKeyMergeOnWriteWithClusterKeys()`
here (or in the enable-feature path before adding the hidden column) and add a
negative enable-feature test for cluster-key tables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
