github-actions[bot] commented on code in PR #63192: URL: https://github.com/apache/doris/pull/63192#discussion_r3253689156
########## regression-test/suites/external_table_p0/tvf/test_local_tvf_iceberg_variant.groovy: ########## @@ -0,0 +1,444 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +import java.net.InetAddress +import java.net.NetworkInterface +import java.nio.file.Files +import java.nio.file.StandardCopyOption +import org.apache.doris.regression.action.ProfileAction + +suite("test_local_tvf_iceberg_variant", "p0,external") { Review Comment: This regression only scans the files through `local(...)`, so it bypasses the actual Iceberg table path changed by this PR. In particular, it does not exercise FE `SlotTypeReplacer.replaceIcebergAccessPathToId()` converting access paths to Iceberg field IDs, nor BE `IcebergParquetReader::_create_column_ids()` calling the Iceberg field-id pruning helper. A bug in field-id access-path serialization or Iceberg-specific column-id selection can therefore pass this suite while failing `SELECT v['...'] FROM iceberg_tbl`. Please add an end-to-end Iceberg external table regression (with nested VARIANT access and profile/read-column assertions where possible) that reads these VARIANT files through the Iceberg catalog/table path rather than only through local TVF. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
