xylaaaaa commented on PR #63376: URL: https://github.com/apache/doris/pull/63376#issuecomment-4484175106
Addressed the actionable review feedback in `92eab4fce4b`:\n\n- Fixed ORC footer ownership on disk-cache hit and remote-read paths by keeping the payload in `std::unique_ptr` until the in-memory cache takes ownership.\n- Applied `external_file_meta_disk_cache_percent` to legacy four-field `file_cache_path` configs when metadata disk cache is enabled, and added BE UT coverage for that case.\n- Added the `read_if_cached` lifetime comment for the lockless read after collecting `FileBlockSPtr` references.\n- Fixed the historical INDEX/DISPOSABLE evict-size bvar label mismatch by indexing metrics with `FileCacheType`.\n\nNot changed in this patch: the Parquet raw-footer-byte split is a follow-up performance optimization; current reserialize path is correct but has extra CPU on first miss. I also rechecked the hit counters and current `disk_cache()` raw pointer usage; no code change needed there for the current stateless implementation.\n\nLocal verification:\n- `build-support/check-for mat.sh`\n- `git diff --check`\n- Tried `./run-be-ut.sh --run --filter=BlockFileCacheTest.file_cache_path_storage_parse -j 8`, but local linking failed before test execution because `thirdparty/installed/lib64/libaws-cpp-sdk-kinesis.a` is missing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
