yiguolei commented on code in PR #63233:
URL: https://github.com/apache/doris/pull/63233#discussion_r3270821289
##########
be/src/storage/segment/column_writer.cpp:
##########
@@ -338,28 +330,25 @@ Status ColumnWriter::create_variant_writer(const
ColumnWriterOptions& opts,
if (column->is_extracted_column()) {
if (column->name().find(DOC_VALUE_COLUMN_PATH) != std::string::npos) {
*writer = std::make_unique<VariantDocCompactWriter>(
- opts, column,
-
std::unique_ptr<StorageField>(StorageFieldFactory::create(*column)));
+ opts, std::make_shared<TabletColumn>(*column));
return Status::OK();
}
VLOG_DEBUG << "gen subwriter for " <<
column->path_info_ptr()->get_path();
- *writer = std::make_unique<VariantSubcolumnWriter>(
- opts, column,
std::unique_ptr<StorageField>(StorageFieldFactory::create(*column)));
+ *writer = std::make_unique<VariantSubcolumnWriter>(opts,
+
std::make_shared<TabletColumn>(*column));
return Status::OK();
}
- *writer = std::make_unique<VariantColumnWriter>(
- opts, column,
std::unique_ptr<StorageField>(StorageFieldFactory::create(*column)));
+ *writer = std::make_unique<VariantColumnWriter>(opts,
std::make_shared<TabletColumn>(*column));
return Status::OK();
}
//Todo(Amory): here should according nullable and offset and need sub to
simply this function
Status ColumnWriter::create(const ColumnWriterOptions& opts, const
TabletColumn* column,
Review Comment:
我们这堆接口传递column*， 我看底下都是copy了一次，为什么不直接传递column的shared ptr啊
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
