JNSimba opened a new pull request, #63435:
URL: https://github.com/apache/doris/pull/63435
### What problem does this PR solve?
During the snapshot phase, the chunk reader (`IncrementalSourceScanFetcher`)
consumes from a change-event queue that may also contain DML records from
**other tables** being captured concurrently. When such a foreign-table
record reached `isChangeRecordInChunkRange`, the code compared it against
the **current chunk's** PK range via `isRecordBetween(...)`. Two problems:
1. The foreign table's schema may not yet be loaded for this fetcher, so
extracting its PK throws NPE.
2. Even if the schema were loaded, the foreign table's PK columns do not
necessarily align with this chunk's bounds, so any range comparison is
meaningless and the record would be incorrectly merged into the wrong
chunk's output buffer.
This patch adds an explicit `TableId` check at the very start of
`isChangeRecordInChunkRange`: records whose `TableId` does not match
`currentSnapshotSplit.getTableId()` are skipped before any PK-based
comparison runs.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
