linrrzqqq commented on code in PR #63143:
URL: https://github.com/apache/doris/pull/63143#discussion_r3274886845
##########
build.sh:
##########
@@ -662,6 +663,14 @@ FE_MODULES="$(
# Clean and build Backend
if [[ "${BUILD_BE}" -eq 1 ]]; then
+
+ echo "install datasketches-cpp to thirdparty path before build be"
+ update_submodule "contrib/datasketches-cpp" "datasketches-cpp"
"https://github.com/apache/datasketches-cpp/archive/refs/tags/5.2.0.tar.gz";
+ cd "${DORIS_HOME}/contrib/datasketches-cpp"
Review Comment:
why maintain through `contrib` instead of `thirdparty`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
