github-actions[bot] commented on code in PR #63344:
URL: https://github.com/apache/doris/pull/63344#discussion_r3278286235
##########
be/src/io/fs/local_file_system.cpp:
##########
@@ -167,6 +167,17 @@ Status LocalFileSystem::delete_directory_or_file(const
Path& path) {
FILESYSTEM_M(delete_directory_or_file_impl(path));
}
+Status LocalFileSystem::delete_empty_directory(const Path& dir) {
Review Comment:
`delete_empty_directory` is a new public `LocalFileSystem` operation, but
unlike the existing public methods such as `link_file`, `md5sum`,
`iterate_directory`, and `copy_path`, it calls the filesystem syscall directly
instead of going through `FILESYSTEM_M`. `FSFileCacheStorage::remove()` is
reached from cache operations that may run in bthreads, so this can block a
bthread worker on `rmdir` and violates the BE IO rule that public `FileSystem`
operations use `FILESYSTEM_M`. Please split this into a public wrapper and an
impl method, e.g. `Status LocalFileSystem::delete_empty_directory(...) {
FILESYSTEM_M(delete_empty_directory_impl(...)); }`, with the current body moved
to the impl.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
