github-actions[bot] commented on code in PR #63456:
URL: https://github.com/apache/doris/pull/63456#discussion_r3278913103
##########
be/src/exec/operator/partitioned_hash_join_probe_operator.cpp:
##########
@@ -407,13 +409,15 @@ Status
PartitionedHashJoinProbeLocalState::recover_probe_blocks_from_partition(
return Status::OK(); // yield — enough data read
}
}
Review Comment:
This fixes the probe-file path, but `recover_build_blocks_from_partition()`
still has the same state-advance gap. That function loops without checking
`state->is_cancelled()` at the end, and if cancellation is already set while
the build reader returns only empty blocks or EOS (which is possible because
level-0 partitions are queued unconditionally), it closes
`_current_build_reader`, resets `partition_info.build_file`, and returns `OK`.
The next pull can then treat the build side as fully recovered instead of
propagating cancellation. Please add the same cancellation guard before the
build path closes/resets the build file, and preferably cover this cancellation
case with a test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
