compasses commented on code in PR #11579:
URL: https://github.com/apache/doris/pull/11579#discussion_r1052961032


##########
be/src/olap/rowset/segment_v2/bloom_filter_index_writer.cpp:
##########
@@ -203,5 +260,22 @@ Status BloomFilterIndexWriter::create(const 
BloomFilterOptions& bf_options,
     return Status::OK();
 }
 
+Status NGramBloomFilterIndexWriterImpl::create(const BloomFilterOptions& 
bf_options,
+                                               const TypeInfo* typeinfo, 
uint8_t gram_size,
+                                               uint16_t gram_bf_size,
+                                               
std::unique_ptr<BloomFilterIndexWriter>* res) {
+    FieldType type = typeinfo->type();
+    switch (type) {
+    case OLAP_FIELD_TYPE_CHAR:
+    case OLAP_FIELD_TYPE_VARCHAR:

Review Comment:
   ok



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to