HappenLee commented on code in PR #15194:
URL: https://github.com/apache/doris/pull/15194#discussion_r1052989486
##########
be/src/pipeline/exec/union_source_operator.cpp:
##########
@@ -61,6 +61,9 @@ Status UnionSourceOperator::get_block(RuntimeState* state,
vectorized::Block* bl
std::unique_ptr<vectorized::Block> output_block;
int child_idx = 0;
_data_queue->get_block_from_queue(&output_block, &child_idx);
+ if (!output_block) {
+ return Status::OK();
+ }
Review Comment:
do not directly return ？ use lower code to dispose the `SourceState`
##########
be/src/vec/exec/join/vhash_join_node.cpp:
##########
@@ -758,7 +758,10 @@ Status HashJoinNode::sink(doris::RuntimeState* state,
vectorized::Block* in_bloc
}
if (_should_build_hash_table && eos) {
- child(1)->close(state);
+ // For pipeline engine, children should be closed once this pipeline
task is finished.
+ if (!state->enable_pipeline_exec()) {
Review Comment:
maybe should do same check in 808line, !_should_build_hash_table
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
