github-actions[bot] commented on code in PR #63519: URL: https://github.com/apache/doris/pull/63519#discussion_r3285797303
########## regression-test/suites/query_p0/expression/topn_to_max.groovy: ########## @@ -1,47 +0,0 @@ -// Licensed to the Apache Software Foundation (ASF) under one -// or more contributor license agreements. See the NOTICE file -// distributed with this work for additional information -// regarding copyright ownership. The ASF licenses this file -// to you under the Apache License, Version 2.0 (the -// "License"); you may not use this file except in compliance -// with the License. You may obtain a copy of the License at -// -// http://www.apache.org/licenses/LICENSE-2.0 -// -// Unless required by applicable law or agreed to in writing, -// software distributed under the License is distributed on an -// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY -// KIND, either express or implied. See the License for the -// specific language governing permissions and limitations -// under the License. - -suite("test_topn_to_max") { - - sql 'drop table if exists test_topn_to_max;' - - sql '''create table test_topn_to_max (k1 int, k2 string) distributed by hash(k1) buckets 3 properties('replication_num' = '1');''' - sql '''insert into test_topn_to_max values (1, "1"), (2, "2");''' - - - order_qt_sql ''' Review Comment: This PR fixes a result-correctness bug, but it deletes the only targeted regression case instead of replacing it with one that validates the new behavior. Please keep or add a regression test where `topn(k2, 1)` would differ from `max(k2)` (for example duplicate a non-maximum value so TOPN returns that value/count while MAX returns another value), and assert the rewritten plan/result does not use `max`. Without this, the unsafe rewrite can be reintroduced later without any targeted test failure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
