bosswnx opened a new pull request, #63537:
URL: https://github.com/apache/doris/pull/63537
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
The original implementation of `WorkloadGroupMetrics::refresh_metrics()`
uses `config::workload_group_metrics_interval_ms / 1000` as a fixed
divisor to compute per-second CPU and scan IO rates. This is inaccurate
when:
1. The refresh thread is delayed due to system load or scheduling jitter
2. The configured interval is changed at runtime
In both cases, the reported per-second CPU/IO rates diverge from reality.
This PR replaces the fixed config-based interval with the actual monotonic
time delta between two consecutive refreshes, so the rates stay
accurate regardless of thread scheduling delays or runtime config changes.
It also adds a division-by-zero guard for sub-second refresh
intervals and corresponding unit tests.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [x] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [x] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
