github-actions[bot] commented on code in PR #63547:
URL: https://github.com/apache/doris/pull/63547#discussion_r3288677986
##########
be/src/exec/exchange/local_exchanger.cpp:
##########
@@ -167,6 +167,9 @@ Status ShuffleExchanger::get_block(RuntimeState* state,
Block* block, bool* eos,
mutable_block = VectorizedUtils::build_mutable_mem_reuse_block(
block, partitioned_block.first->_data_block);
RETURN_IF_ERROR(get_data());
+ if (mutable_block.rows() > 0) {
+ *block = mutable_block.to_block();
Review Comment:
This same `MutableBlock` handoff fix is applied to `ShuffleExchanger` here
and to `BroadcastExchanger` below, but the new regression test only exercises
`AdaptivePassthroughExchanger`. The failure mode depends on
`build_mutable_mem_reuse_block()` mutating an output block whose column is
shared, so existing tests that call these exchangers with a fresh `Block` would
not catch a regression in the shuffle or broadcast paths. Please add equivalent
shared-output-column coverage for the changed shuffle and broadcast
`get_block()` paths, or otherwise prove these two paths are covered by an
existing test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
