github-actions[bot] commented on code in PR #63546:
URL: https://github.com/apache/doris/pull/63546#discussion_r3288782254
##########
be/src/exec/operator/exchange_sink_buffer.h:
##########
@@ -310,13 +310,13 @@ class ExchangeSinkBuffer : public HasTaskExecutionCtx {
#ifndef BE_TEST
inline void _ended(RpcInstance& ins);
- inline void _failed(InstanceLoId id, const std::string& err);
+ inline void _failed(InstanceLoId id, Status err);
inline void _set_receiver_eof(RpcInstance& ins);
inline void _turn_off_channel(RpcInstance& ins,
std::unique_lock<std::mutex>& with_lock);
#else
virtual void _ended(RpcInstance& ins);
- virtual void _failed(InstanceLoId id, const std::string& err);
+ virtual void _failed(InstanceLoId id, Status err);
Review Comment:
This signature change breaks the BE test mock override.
`be/test/exec/exchange/exchange_sink_test.h` still declares `void
_failed(InstanceLoId id, const std::string& err) override`, so when tests are
built with `BE_TEST` the override no longer matches
`ExchangeSinkBuffer::_failed(InstanceLoId, Status)` and compilation will fail.
Please update the mock (and any other BE_TEST overrides) to take `Status`, or
avoid changing the virtual test-only signature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
