boluor opened a new pull request, #3748:
URL: https://github.com/apache/doris-website/pull/3748

   ## Summary
   
   Fixes #3124. The reporter pointed out that every non-HDFS example on the 
\`CREATE-STORAGE-VAULT\` page uses \`\"type\" = \"S3\"\` and \`s3.access_key\` 
/ \`s3.secret_key\` — for OSS, COS, OBS, BOS, MinIO, Azure Blob, and GCS — 
which reads as a copy-paste mistake.
   
   It is not a bug. The FE \`StorageVaultType\` enum at 
[\`fe/fe-core/src/main/java/org/apache/doris/catalog/StorageVault.java\`](https://github.com/apache/doris/blob/master/fe/fe-core/src/main/java/org/apache/doris/catalog/StorageVault.java#L51-L65)
 defines only two values, \`S3\` and \`HDFS\` (verified identical on 
\`branch-3.0\`, \`branch-3.1\`, \`branch-4.0\`, \`branch-4.1\`). All 
object-storage backends speak to Doris through the S3-compatible client; the 
actual cloud is selected by the separate \`provider\` property (\`COS\`, 
\`OSS\`, \`S3\`, \`OBS\`, \`BOS\`, \`AZURE\`, \`GCP\`). The \`s3.*\` property 
prefix follows the same S3-API convention and is not literally about AWS S3.
   
   This PR adds a \`:::note\` admonition immediately before the \`### S3 
Vault\` parameters table on all six maintained pages (current/3.x/4.x EN + zh), 
so first-time readers don't read the examples as duplicated.
   
   ## Scope
   
   6 files, +24 lines, +0 lines removed:
   - \`docs/.../CREATE-STORAGE-VAULT.md\` (current EN)
   - \`versioned_docs/version-3.x/.../CREATE-STORAGE-VAULT.md\`
   - \`versioned_docs/version-4.x/.../CREATE-STORAGE-VAULT.md\`
   - \`i18n/zh-CN/.../current/.../CREATE-STORAGE-VAULT.md\`
   - \`i18n/zh-CN/.../version-3.x/.../CREATE-STORAGE-VAULT.md\`
   - \`i18n/zh-CN/.../version-4.x/.../CREATE-STORAGE-VAULT.md\`
   
   No changes to existing examples or parameter tables. \`version-2.1\` does 
not have the storage-vault feature so no edit needed there.
   
   ## Test plan
   
   - [x] Note placed directly above \`### S3 Vault\` table on all 6 pages
   - [x] Dead-link check passes
   - [x] No example code changed
   
   Closes #3124


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to