yx-keith opened a new pull request, #63567:
URL: https://github.com/apache/doris/pull/63567
…w constant overflows (#61761)
date_sub(i, interval 1 day) <= '9999-12-31' was being rewritten to i <=
days_add('9999-12-31', 1). The new constant overflows the DATE domain, but the
rule did not detect this: FoldConstantRule.evaluate swallows exceptions in
non-debug mode and returns the unfolded expression, so the overflow leaked to
runtime as
"Operation day_add of 9999-12-31 00:00:00, 1 out of range".
Eagerly fold the rearranged constant inside tryRearrangeChildren when both
sides are literals. A non-Literal result means folding failed, in which case we
throw so the outer try/catch falls back to the original comparison. This covers
the symmetric overflow case for every operator pair in REARRANGEMENT_MAP
(days/weeks/hours/minutes/ seconds + numeric add/sub/divide).
Also add unit tests for the date overflow cases and a regression test based
on the original repro.
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
