github-actions[bot] commented on code in PR #15199:
URL: https://github.com/apache/doris/pull/15199#discussion_r1053931207
##########
be/src/vec/exec/scan/scanner_scheduler.cpp:
##########
@@ -235,12 +235,16 @@ void ScannerScheduler::_scanner_scan(ScannerScheduler*
scheduler, ScannerContext
VLOG_ROW << "VOlapScanNode input rows: " << block->rows() << ", eos: "
<< eos;
// The VFileScanner for external table may try to open not exist files,
// Because FE file cache for external table may out of date.
- if (!status.ok() && (typeid(*scanner) ==
typeid(doris::vectorized::VFileScanner) &&
- !status.is<ErrorCode::NOT_FOUND>())) {
- LOG(WARNING) << "Scan thread read VOlapScanner failed: " <<
status.to_string();
- // Add block ptr in blocks, prevent mem leak in read failed
- blocks.push_back(block);
- break;
+ if (!status.ok()) {
+ auto type_id_scanner = typeid(*scanner);
Review Comment:
warning: calling a private constructor of class 'std::type_info'
[clang-diagnostic-error]
```cpp
auto type_id_scanner = typeid(*scanner);
^
```
**/usr/include/c++/11/typeinfo:180:** declared private here
```cpp
type_info(const type_info&);
^
```
##########
be/src/vec/exec/scan/scanner_scheduler.cpp:
##########
@@ -235,12 +235,16 @@
VLOG_ROW << "VOlapScanNode input rows: " << block->rows() << ", eos: "
<< eos;
// The VFileScanner for external table may try to open not exist files,
// Because FE file cache for external table may out of date.
- if (!status.ok() && (typeid(*scanner) ==
typeid(doris::vectorized::VFileScanner) &&
- !status.is<ErrorCode::NOT_FOUND>())) {
- LOG(WARNING) << "Scan thread read VOlapScanner failed: " <<
status.to_string();
- // Add block ptr in blocks, prevent mem leak in read failed
- blocks.push_back(block);
- break;
+ if (!status.ok()) {
+ auto type_id_scanner = typeid(*scanner);
+ auto type_id_file_scanner =
typeid(doris::vectorized::VFileScanner);
Review Comment:
warning: calling a private constructor of class 'std::type_info'
[clang-diagnostic-error]
```cpp
auto type_id_file_scanner =
typeid(doris::vectorized::VFileScanner);
^
```
**/usr/include/c++/11/typeinfo:180:** declared private here
```cpp
type_info(const type_info&);
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
