github-actions[bot] commented on code in PR #63587:
URL: https://github.com/apache/doris/pull/63587#discussion_r3297950404
##########
regression-test/suites/point_query_p0/test_point_query_ck.groovy:
##########
@@ -17,7 +17,7 @@
import java.math.BigDecimal;
-suite("test_point_query_ck") {
+suite("test_point_query_ck", "nonConcurrent") {
Review Comment:
This only moves `test_point_query_ck` into the `nonConcurrent` phase, but
the sibling `regression-test/suites/point_query_p0/test_point_query.groovy`
suite is still declared as `suite("test_point_query")`. That suite also mutates
process-wide FE state (`ADMIN SET FRONTEND CONFIG
("enable_lightweight_lookup_request" = ...)`), and the regression framework
runs NORMAL suites concurrently before SINGLE suites
(`RegressionTest.runScripts` waits for NORMAL futures before running
`GroupExecType.SINGLE`). So this PR prevents `test_point_query_ck` from
overlapping with normal suites, but `test_point_query` can still overlap with
other normal suites and cause the same class of global-config interference that
the PR title says should be fixed. Please mark `test_point_query` as
`nonConcurrent` too, or otherwise explain why only the CK variant needs
serialization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
