github-actions[bot] commented on code in PR #63612:
URL: https://github.com/apache/doris/pull/63612#discussion_r3302062534
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java:
##########
@@ -7553,6 +7560,35 @@ public NereidsSortedPartitionsCacheManager
getSortedPartitionsCacheManager() {
return sortedPartitionsCacheManager;
}
+ public void notifyTableMetaChange(TableIf table) {
+ if (table == null) {
+ return;
+ }
+ TableMetaChange change =
+ TableMetaChange.fromTable(table);
Review Comment:
This makes the invalidation durable only as a second edit-log record after
the real metadata mutation has already been logged by the caller. If the master
crashes after the metadata log is committed but before this
`OP_TABLE_META_CHANGE` is committed, the promoted FE replays the
schema/property change but never replays this invalidation, so its existing SQL
cache can keep serving stale results indefinitely. For example, `ALTER TABLE
... RENAME COLUMN` logs the rename in the alter path, then reaches
`notifyTableMetaChange`; a crash in this window recreates the original
follower-cache bug this PR is fixing. The invalidation needs to be tied to
replaying the metadata operation itself, or otherwise made atomic with the
metadata journal entry, rather than relying on a best-effort follow-up journal
record.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
