Mryange opened a new pull request, #63678:
URL: https://github.com/apache/doris/pull/63678
### What problem does this PR solve?
Array and map offset subcolumns were still stored and exposed through
generic IColumn pointers, so callers had to repeatedly downcast them back to
their concrete offset column types. Root cause: the ownership, COW mutation,
deserialization, and segment reader write-back paths still treated these
offsets as generic subcolumns, which left the strong-typing change incomplete
and kept redundant same-type assert_cast usage in affected callers and tests.
This change promotes ColumnArray offsets and ColumnMap offsets_column to typed
wrapped pointers, updates the typed accessors and generic write-back paths to
preserve the concrete offset column type, and removes the now-redundant casts
in array functions, lambda functions, and unit tests. It also cleans up one
redundant nullable null-map cast uncovered during the BE UT compile.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
