airborne12 opened a new pull request, #63701:
URL: https://github.com/apache/doris/pull/63701
## Proposed changes
Issue Number: close #N/A
### What problem does this PR solve?
BE-UT has been failing master-wide since both #63491 (strongly typed
`ColumnNullable::get_null_map_column[_ptr]()` to \`ColumnUInt8\`) and #63049
(added \`functions_geo_test.cpp\`) landed today. The new test calls:
\`\`\`cpp
assert_cast<ColumnUInt8*>(nullable_input->get_null_map_column_ptr().get())
->insert_value(0);
\`\`\`
The inner expression is now already \`ColumnUInt8*\`, so the cast hits the
same-type static_assert added by #63133 in \`src/core/assert_cast.h\`:
\`\`\`
static assertion failed due to requirement
'!std::is_same_v<doris::ColumnVector<doris::TYPE_BOOLEAN> *,
doris::ColumnVector<doris::TYPE_BOOLEAN> *>':
assert_cast is redundant for the same type after removing cv/ref
qualifiers
\`\`\`
That kills \`doris_be_test\` compilation on every PR that exercises BE-UT
(e.g. #63692 953796, ##63637 953796).
Use the strongly typed \`get_null_map_column()\` (which returns
\`ColumnUInt8&\`) directly so no cast is needed.
### Release note
None (test-only change, restores BE-UT compilation on master).
### Check List (For Author)
- [x] Test: Local ASAN ninja build of the affected translation unit
(\`test/CMakeFiles/doris_be_test.dir/exprs/function/geo/functions_geo_test.cpp.o\`)
is clean after this change.
- [x] Behavior changed: No
- [x] Does this need documentation: No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
