github-actions[bot] commented on code in PR #63696:
URL: https://github.com/apache/doris/pull/63696#discussion_r3308868096
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/TableProperty.java:
##########
@@ -194,6 +195,17 @@ public TableProperty buildProperty(short opCode) {
*/
public TableProperty resetPropertiesForRestore(boolean
reserveDynamicPartitionEnable, boolean reserveReplica,
ReplicaAllocation
replicaAlloc) {
+ if (Config.isCloudMode()) {
+ // In cloud mode, rewrite all unsupported or forced properties
from the source cluster.
+ // These properties (e.g., replication_num,
replication_allocation, storage_policy,
Review Comment:
This still leaves `dynamic_partition.storage_policy` from the backup
metadata in cloud mode. The current code now relies on
`CloudPropertyAnalyzer.rewriteForceProperties()`, but that analyzer deletes
table-level `storage_policy` and `dynamic_partition.storage_medium`; it does
not delete `DynamicPartitionProperty.STORAGE_POLICY`. When
`reserveDynamicPartitionEnable` is true, the subsequent
`executeBuildDynamicProperty()` builds a `DynamicPartitionProperty` with the
source storage policy, and `DynamicPartitionScheduler.getAddPartitionOp()`
copies it into every generated partition via `setStoragePolicyProperty()`. That
is a distinct remaining path from the already-mentioned storage-medium cleanup:
dynamic partitions restored in cloud can still be created with a source-cluster
storage policy. Please also normalize/remove `dynamic_partition.storage_policy`
for cloud restore and cover it in the cloud restore test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
