mrhhsg commented on PR #63528: URL: https://github.com/apache/doris/pull/63528#issuecomment-4552056546
Self-review after addressing the request change: - Rechecked FE validation for ARRAY/MAP/STRUCT literal defaults and JSON/VARIANT DEFAULT NULL-only behavior. - Rechecked BE default materialization path: `DefaultValueColumnIterator` now uses the column SerDe, and complex nested values use strict conversion for non-NULL literals. - Rechecked ARRAY/MAP/STRUCT SerDe parsing, including nested type-mismatch failure propagation. - Rechecked regression coverage for positive defaults, DEFAULT NULL, ALTER ADD COLUMN materialization, and type-mismatched ARRAY/MAP/STRUCT defaults. No additional issue found in the updated patch. Local validation: - `build-support/clang-format.sh` - `build-support/check-format.sh` - `git diff --check` - `./build.sh --be` - `doris-local-regression --network 10.26.20.3/24 run -d datatype_p0/complex_types -s test_complex_default_value` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
