github-actions[bot] commented on code in PR #63645:
URL: https://github.com/apache/doris/pull/63645#discussion_r3310232530
##########
regression-test/suites/auth_call/test_show_charset_auth.groovy:
##########
@@ -65,7 +65,8 @@ suite("test_show_no_auth","p0,auth_call") {
def res1 = sql """SHOW PROCESSLIST"""
logger.info("res1: " + res1)
- assertTrue(res1.size() == 1)
+ def ownSessions = res1.findAll { it[2] == user }
Review Comment:
This makes the auth test pass even when `SHOW PROCESSLIST` returns sessions
owned by other users. In the local path, `ConnectPoolMgr.listConnection()` only
includes other users for ADMIN callers, so this test previously asserted the
non-admin `grant_priv` user did not get extra rows. The new `findAll` keeps the
test green while accepting the leaked/extra rows that caused the flake. Please
keep the authorization invariant, for example by isolating this statement from
all-FE collection (`set fetch_all_fe_for_system_table=false` around this check)
and asserting all returned rows belong to `${user}` or that the size remains
exactly one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
