kaka11chen commented on code in PR #63666:
URL: https://github.com/apache/doris/pull/63666#discussion_r3310430092
##########
be/src/storage/segment/segment_iterator.cpp:
##########
@@ -1386,14 +1390,6 @@ Status SegmentIterator::_apply_index_expr() {
_opts.stats->ann_index_range_cache_hits +=
ann_index_stats.range_cache_hits.value();
}
- for (auto it = _common_expr_ctxs_push_down.begin(); it !=
_common_expr_ctxs_push_down.end();) {
Review Comment:
这边统一 erase 了。
```
// Always apply expr-level index (e.g., search expressions) if
we have common_expr_pushdown
// This allows search expressions with variant subcolumns to be
evaluated even when
// the segment doesn't have all subcolumns
RETURN_IF_ERROR(_apply_index_expr());
for (auto it = _common_expr_ctxs_push_down.begin();
it != _common_expr_ctxs_push_down.end();) {
if ((*it)->all_expr_inverted_index_evaluated()) {
const auto* result =
(*it)->get_index_context()->get_index_result_for_expr(
(*it)->root().get());
if (result != nullptr) {
_row_bitmap &= *result->get_data_bitmap();
it = _common_expr_ctxs_push_down.erase(it);
}
} else {
++it;
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
