github-actions[bot] commented on code in PR #63612:
URL: https://github.com/apache/doris/pull/63612#discussion_r3314907259
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java:
##########
@@ -7131,7 +7132,9 @@ public void setTableStatusInternal(String dbName, String
tableName, OlapTableSta
LOG.warn("ignore set same state {} for table {}. is replay:
{}.",
olapTable.getState(), tableName, isReplay);
}
-
Env.getCurrentEnv().getSqlCacheManager().invalidateAboutTable(olapTable);
+ if (!isReplay) {
+ notifyTableMetaChange(olapTable);
Review Comment:
This drops the replay-side invalidation for older or mixed-version journals
that only contain `OP_SET_TABLE_STATUS` and do not have the new
`OP_TABLE_META_CHANGE` companion record. During a rolling upgrade, a newly
upgraded follower can still replay logs produced by an older master; previously
this method invalidated the SQL cache on replay, but now `isReplay == true`
skips it and no later table-meta-change record exists to compensate. The same
pattern below affects `setReplicaVersionInternal` and
`setPartitionVersionInternal`. This is distinct from the already-raised
second-edit-log crash window: here the companion edit log is absent by version
compatibility, not merely delayed or lost after a crash. Please keep replay
invalidation for old standalone records, or gate the skip on a replay
format/version that proves an `OP_TABLE_META_CHANGE` record will follow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
