github-actions[bot] commented on code in PR #63828:
URL: https://github.com/apache/doris/pull/63828#discussion_r3318273424
##########
regression-test/suites/variant_p0/variant_hirachinal.groovy:
##########
@@ -47,8 +47,8 @@ suite("regression_test_variant_hirachinal", "variant_type"){
qt_sql "select cast(v['c'] as string) from ${table_name} where k = -3 or k
= -2 order by k"
qt_sql "select v['b'] from ${table_name} where k = -3 or k = -2"
sql """insert into ${table_name} values (-3, '{"c" : 12345}')"""
- order_qt_sql1 "select cast(v['c'] as string) from var_rs where k = -3 or k
= -2 or k = -4 or (k = 1 and v['c'] = 1024) order by k"
- order_qt_sql2 "select cast(v['c'] as string) from var_rs where k = -3 or k
= -2 or k = 1 order by k, cast(v['c'] as text) limit 3"
+ order_qt_sql1 "select cast(v['c'] as json) from var_rs where k = -3 or k =
-2 or k = -4 or (k = 1 and v['c'] = 1024) order by k"
+ order_qt_sql2 "select cast(v['c'] as json) from var_rs where k = -3 or k =
-2 or k = 1 order by k, cast(v['c'] as text) limit 3"
Review Comment:
This fixes two checked outputs, but the immediately preceding `qt_sql` still
runs `select cast(v['c'] as string) ... where k = -3 or k = -2` and its
expected output includes the same array/object variant serialization (`[1, 2,
3]`) that the PR says can vary as `[1,2,3]` under fuzzed session variables.
Since `qt_sql` is also result-checked, the suite can still fail for the same
reason before reaching these two queries. Please convert that earlier checked
query to the stable serialization path as well, or explain why it cannot hit
the same flaky path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
