github-actions[bot] commented on code in PR #63894:
URL: https://github.com/apache/doris/pull/63894#discussion_r3333602525
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/doris/FeServiceClient.java:
##########
@@ -310,12 +307,16 @@ public RemoteOlapTable getOlapTable(String dbName, String
table, long tableId, L
// rebuild temp partitions
if (result.isSetUpdatedTempPartitions() &&
result.getUpdatedTempPartitionsSize() > 0) {
updatedPartitions = new
ArrayList<>(result.getUpdatedTempPartitionsSize());
- for (ByteBuffer buffer : result.getUpdatedTempPartitions()) {
+ updatedPartitionChecksums =
result.isSetUpdatedTempPartitionChecksums()
Review Comment:
`updatedPartitions` still contains the normal partition updates when
`updated_temp_partitions` is unset or empty. With this PR, a common
relocation-only refresh returns `updated_partitions` because the checksum
changed, but no temp updates; this condition is skipped and the code then calls
`rebuildTempPartitions(tempPartitions, updatedPartitions, removedPartitions)`,
inserting those normal partitions into the temp-partition map. Please use a
separate `updatedTempPartitions` list initialized to empty before this block,
populate it only from `updated_temp_partitions`, and pass that list to
`rebuildTempPartitions`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
