github-actions[bot] commented on code in PR #63969:
URL: https://github.com/apache/doris/pull/63969#discussion_r3334571178
##########
be/src/exec/operator/scan_operator.cpp:
##########
@@ -1250,11 +1250,6 @@ Status
ScanOperatorX<LocalStateType>::prepare(RuntimeState* state) {
_slot_id_to_slot_desc[slot->id()] = slot;
}
for (auto id : _topn_filter_source_node_ids) {
- if (!state->get_query_ctx()->has_runtime_predicate(id)) {
- // compatible with older versions fe
- continue;
- }
-
int cid = -1;
Review Comment:
The new `column_id < 0` fallback does not cover slot targets whose storage
predicate is skipped for `TYPE_VARBINARY`. In this loop `cid` starts at `-1`,
but the later VARBINARY branch still `continue`s before calling
`init_target()`, so `_detected_target` remains false and
`get_topn_filter_source_node_ids()` filters the runtime predicate out.
`RuntimePredicate::_init()` and `VTopNPred` both support varbinary comparisons,
so this should fall back to `init_target(node_id(), ..., -1)` instead of
leaving the TopN runtime filter disabled for `ORDER BY varbinary_col LIMIT ...`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
