xylaaaaa commented on PR #63783: URL: https://github.com/apache/doris/pull/63783#issuecomment-4598167878
Addressed the review comments in `0a2e362fadf`: - Use `Locale.ROOT` for Snowflake JDBC URL prefix checks. - Parse query parameters for `authenticator=oauth` in FE and BE instead of substring matching, avoiding `oauth2` false positives. - Use `URLEncoder.encode(value, StandardCharsets.UTF_8)` for Snowflake database/warehouse URL parameters. - Align Snowflake fallback `Types.FLOAT` / `Types.REAL` mapping with Snowflake `FLOAT` type-name mapping by returning `DOUBLE`. - Remove the redundant `SNOWFLAKE` branch in `JdbcTypeHandlerFactory` and rely on the default handler. - Add tests for OAuth exact matching and Snowflake float fallback mapping. Re-run tests: - FE JDBC connector focused tests: 135 passed, 0 failed. - BE JDBC scanner Snowflake auth test: 4 passed, 0 failed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
