wyxxxcat opened a new pull request, #63985:
URL: https://github.com/apache/doris/pull/63985
### What problem does this PR solve?
Problem Summary:
`commit_rowset` needs to distinguish two key states to preserve idempotency
and prevent invalid commits:
1. If the tmp rowset key already exists, the recycle rowset key must not
exist. Otherwise, the two keys are mutually exclusive and the retry should fail.
2. If the tmp rowset key does not exist, the recycle rowset key must exist
before creating the tmp rowset key. Otherwise, the request may bypass the
prepare-rowset state and commit an invalid rowset.
This change reorganizes the recycle rowset key check in `commit_rowset` to
first check the tmp rowset key, then validate the recycle rowset key according
to the tmp key state. It also simplifies the helper by returning whether the
recycle key check succeeds and exposing whether the recycle key exists through
an output parameter.
A unit test is added to cover both invalid states:
- tmp rowset key exists while recycle rowset key also exists
- tmp rowset key does not exist while recycle rowset key is missing
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
