yujun777 commented on code in PR #63850:
URL: https://github.com/apache/doris/pull/63850#discussion_r3338489327
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/stream/BaseTableStream.java:
##########
@@ -57,12 +60,26 @@ public static StreamConsumeType getType(String typeName) {
return UNKNOWN;
}
}
+
+ public static TBinlogScanType toThrift(StreamScanType streamScanType) {
+ switch (streamScanType) {
+ case DEFAULT:
+ case MIN_DELTA:
+ return TBinlogScanType.MIN_DELTA;
Review Comment:
in file OlapTableStream.java, for a dup key table, if its scan type is
default, then convert it to APPEND_ONLY. but for here, the default is set to
MIN_DELTA. so the scan type DEFAULT may set to different scan type ? i have
a question, if we need the DEFAULT scan type here, can we remove it ? Also,
for dup table, maybe it's append only or min_delta are same ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
