eldenmoon commented on code in PR #63970:
URL: https://github.com/apache/doris/pull/63970#discussion_r3338596499
##########
be/src/exec/common/variant_util.cpp:
##########
@@ -2247,8 +2250,23 @@ Status parse_and_materialize_variant_columns(Block&
block, const TabletSchema& t
return Status::InternalError("column is not variant type, column
name: {}",
column.name());
}
- // if doc mode is not enabled, no need to parse to doc value column
- if (!column.variant_enable_doc_mode()) {
+ // NestedGroup still needs the legacy subcolumn parse tree to build NG
data.
+ if (column.variant_enable_nested_group()) {
+ configs[i].parse_to = ParseConfig::ParseTo::OnlySubcolumns;
+ continue;
+ }
+
+ if (column.variant_enable_doc_mode()) {
+ configs[i].parse_to = ParseConfig::ParseTo::OnlyDocValueColumn;
+ continue;
+ }
+
+ // The doc-value KV staging path intentionally targets plain dynamic
VARIANT columns: it
+ // avoids eagerly creating thousands of dynamic subcolumns and lets
the writer pick the
+ // materialized/sparse split. Keep legacy subcolumn parsing for cases
where parse-time path
+ // metadata or schema/index behavior is part of the storage contract.
+ if (configs[i].deprecated_enable_flatten_nested ||
column.get_subtype_count() > 0 ||
Review Comment:
why `column.get_subtype_count() > 0 ||
!tablet_schema.inverted_indexs(column.unique_id()).empty() ` should be
`OnlySubcolumns`， What if using `OnlyDocValueColumn`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
