github-actions[bot] commented on code in PR #60209:
URL: https://github.com/apache/doris/pull/60209#discussion_r3339036843
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/BrokerMgr.java:
##########
@@ -392,6 +393,7 @@ public ProcResult fetchResult() {
row.add(TimeUtils.longToTimeString(broker.lastStartTime));
row.add(TimeUtils.longToTimeString(broker.lastUpdateTime));
Review Comment:
This resolves DNS while `BrokerMgr.lock` is still held by
`BrokerProcNode.fetchResult()`. `HostUtils.resolveHostToIp()` calls
`InetAddress.getByName()`, which may block on external DNS; during that time
broker add/drop/replay and normal broker lookups that need the same lock are
stalled. Please snapshot the broker rows under the lock and resolve IPs after
releasing it, or cache/store the resolved address outside this metadata lock.
This is distinct from the existing review thread, which only covered where the
new column is placed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
