github-actions[bot] commented on code in PR #63586:
URL: https://github.com/apache/doris/pull/63586#discussion_r3339721551
##########
regression-test/suites/nereids_p0/stats/partitionRowCount.groovy:
##########
@@ -35,7 +35,7 @@ suite("partitionRowCount") {
sql """physical plan
select * from partitionRowCountTable where a < 250;
"""
- contains("PhysicalOlapScan[partitionRowCountTable partitions(2/3)]@0 (
stats=4, operativeSlots=[a#0]")
+ contains("table=partitionRowCountTable partitions(2/3)")
}
Review Comment:
This weakens the regression test so it no longer checks the bug this suite
is named for. Before this PR the assertion required `stats=4`; now it only
verifies that two partitions are selected, so a regression in partition
row-count estimation would still pass. Please keep the id-independent part of
the new format but include the row count, for example by matching
`table=partitionRowCountTable partitions(2/3), stats=4` or by adding a separate
`contains("stats=4")` assertion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
