nsivarajan commented on code in PR #60921:
URL: https://github.com/apache/doris/pull/60921#discussion_r3340033183
##########
fe/fe-core/src/main/java/org/apache/doris/httpv2/rest/manager/HttpUtils.java:
##########
@@ -60,18 +61,21 @@ public class HttpUtils {
static final int DEFAULT_TIME_OUT_MS = 2000;
public static List<Pair<String, Integer>> getFeList() {
+ int port = Config.enable_https ? Config.https_port : Config.http_port;
return Env.getCurrentEnv().getFrontends(null)
- .stream().filter(Frontend::isAlive).map(fe ->
Pair.of(fe.getHost(), Config.http_port))
+ .stream().filter(Frontend::isAlive).map(fe ->
Pair.of(fe.getHost(), port))
.collect(Collectors.toList());
}
static boolean isCurrentFe(String ip, int port) {
Review Comment:
@morningman Thanks for the review!
Just to clarify — isCurrentFe is actually used at
QueryProfileAction.java:347, where it acts as a guard to skip the current FE
node during the cluster-wide trace ID fan-out loop (to avoid the node
forwarding a request to itself). Happy to add a more descriptive Javadoc if
that would make it clearer.
https://github.com/apache/doris/blob/07b497ab2192a8eb3ccfe1e0c41a48123c646e1e/fe/fe-core/src/main/java/org/apache/doris/httpv2/rest/manager/QueryProfileAction.java#L347
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
