github-actions[bot] commented on code in PR #64019:
URL: https://github.com/apache/doris/pull/64019#discussion_r3340167988
##########
be/src/exec/operator/scan_operator.cpp:
##########
@@ -1307,7 +1307,7 @@ Status
ScanOperatorX<LocalStateType>::prepare(RuntimeState* state) {
.nodes[0]
.slot_ref.slot_id];
DCHECK(s != nullptr);
- if (remove_nullable(s->type())->get_primitive_type() ==
TYPE_VARBINARY) {
+ if (!can_push_down_column_predicate(s)) {
Review Comment:
This `continue` now disables the whole TopN runtime predicate for file-scan
VARBINARY targets. For `FileScanOperatorX::can_push_down_column_predicate()`
the check returns false, so `RuntimePredicate::init_target()` is never called
and `_detected_target` remains false. Later `get_topn_filter_source_node_ids()`
skips the id because `pred.enable()` is false, so `_get_topn_filters()` does
not add even the residual `VTopNPred` conjunct. The intended limitation is only
that external readers cannot accept the column predicate; the scan should still
initialize the target with `cid = -1` so `_push_down_topn()` returns false and
the filter remains as a normal conjunct. Please avoid `continue` here for the
non-pushdown case and still call `init_target(..., -1)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
