github-actions[bot] commented on code in PR #63228:
URL: https://github.com/apache/doris/pull/63228#discussion_r3340168890
##########
regression-test/pipeline/common/doris-utils.sh:
##########
@@ -674,17 +674,19 @@ archive_doris_logs() {
(
cd "${DORIS_HOME}" || return 1
cp --parents -rf "fe/conf" "${archive_dir}"/
+ if sed -i
"s/${hwYunAk:-}//g;s/${hwYunSk:-}//g;s/${s3SourceAk:-}//g;s/${s3SourceSk:-}//g;s/${txYunAk:-}//g;s/${txYunSk:-}//g"
fe/log/* &>/dev/null; then :; fi
Review Comment:
This redaction can be skipped in normal cloud/vault runs when the optional
Huawei credentials are unset. `cloud_p0/run.sh` and `vault_p0/run.sh` require
`s3SourceAk/s3SourceSk` but only warn for missing `hwYunAk/hwYunSk`; with
`hwYunAk` empty this expands to an invalid leading `sed` expression
(`s//g...`), `sed` exits before processing the later required S3 credentials,
and the failure is suppressed by `&>/dev/null`, so the archive can still
contain `s3SourceAk/s3SourceSk`. Please build the redaction script only from
non-empty values (and apply the same fix to the duplicated BE/regression/conf
redaction lines) instead of interpolating empty variables directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
